Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Z3SolverContext cellCache #1703

Merged
merged 3 commits into from
May 3, 2022
Merged

Refactor Z3SolverContext cellCache #1703

merged 3 commits into from
May 3, 2022

Conversation

rodrigo7491
Copy link
Collaborator

@rodrigo7491 rodrigo7491 commented May 2, 2022

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entry added to UNRELEASED.md for any new functionality

This PR refactors updates to cellCache to not happen during iterations. Closes #1595.

@rodrigo7491 rodrigo7491 requested a review from konnov May 2, 2022 14:51
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #1703 (d06a4c7) into unstable (7823b14) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           unstable    #1703   +/-   ##
=========================================
  Coverage     75.31%   75.32%           
=========================================
  Files           357      357           
  Lines         11541    11541           
  Branches        576      595   +19     
=========================================
+ Hits           8692     8693    +1     
+ Misses         2849     2848    -1     
Impacted Files Coverage Δ
...rsyte/apalache/tla/bmcmt/smt/Z3SolverContext.scala 81.18% <100.00%> (ø)
...he/io/annotations/parser/CommentPreprocessor.scala 96.70% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7823b14...d06a4c7. Read the comment docs.

@rodrigo7491 rodrigo7491 merged commit 0fff5ac into unstable May 3, 2022
@rodrigo7491 rodrigo7491 deleted the ro/cache_refactor branch May 3, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Z3SolverContext caches
3 participants