Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined results from model evaluation #1820

Merged
merged 2 commits into from
May 25, 2022
Merged

Conversation

rodrigo7491
Copy link
Collaborator

@rodrigo7491 rodrigo7491 commented May 25, 2022

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

This PR makes makes the solver context query Z3 if a model evaluation returns an undefined result. See the linked issue for details. Closes #1819.

@p-offtermatt p-offtermatt mentioned this pull request May 25, 2022
2 tasks
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Looks good!

@rodrigo7491
Copy link
Collaborator Author

@konnov I will merge this now, because I think the updated treatment of UNDEF is an improvement in any case. I opened an issue in the Z3 repo (Z3Prover/z3#6053) to see if this is indeed a bug in the solver.

@rodrigo7491 rodrigo7491 merged commit 22dddfa into unstable May 25, 2022
@rodrigo7491 rodrigo7491 deleted the ro/eval-fix branch May 25, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined solver evaluation leading to spurious counter-example
2 participants