-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PostTypeChecker #1878
Remove PostTypeChecker #1878
Conversation
Codecov Report
@@ Coverage Diff @@
## unstable #1878 +/- ##
============================================
- Coverage 76.75% 76.67% -0.09%
============================================
Files 400 401 +1
Lines 12305 12319 +14
Branches 574 575 +1
============================================
Hits 9445 9445
- Misses 2860 2874 +14
Continue to review full report at Codecov.
|
Thank you for factoring out for a smaller review. I'll wait to review here until the integration tests are passing. |
This PR has passing tests. @Kukovec, @shonfeder, do you have free cycles to review this PR? |
Blocked by #1880.Extracted from #1870, as it requires more work on the integration tests.
Closes #1323. Removed the PostTypeChecker pass, as it was really stepping in the way, producing incomprehensible error messages. This started to happen in conjunction with row types, which can be quite tricky to understand when they contain a free variable. This feature should have been implemented in a separate PR, but it was too late. Here are the affected files:
deleted PostTypeCheckerPassImpl.scala
added MonotypeLanguagePred that ensures that all types are monotypes
placed an additional check with MonotypeLanguagePred in BoundedCheckerPassImpl
added/changed a few additional classes ReTLACombinedPredicate.scala, ReTLAToVMTModule.scala.
Ran
make fmt-fix
(or had formatting run automatically on all files edited)Entries added to ./unreleased/ for any new functionality