Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HOWTO on types #1940

Merged
merged 9 commits into from
Jul 8, 2022
Merged

Update HOWTO on types #1940

merged 9 commits into from
Jul 8, 2022

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Jul 7, 2022

Closes #1938. This PR updates the HOWTO on types, explaining how to specify new record types and variants.

@konnov konnov requested review from bugarela and Kukovec July 7, 2022 18:04
@konnov konnov requested a review from shonfeder as a code owner July 7, 2022 18:04
Copy link
Collaborator

@bugarela bugarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #1940 (9b9b936) into unstable (a13c5d5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           unstable    #1940      +/-   ##
============================================
- Coverage     77.08%   77.07%   -0.01%     
============================================
  Files           415      415              
  Lines         12668    12668              
  Branches        569      569              
============================================
- Hits           9765     9764       -1     
- Misses         2903     2904       +1     
Impacted Files Coverage Δ
...he/io/annotations/parser/CommentPreprocessor.scala 96.70% <0.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13c5d5...9b9b936. Read the comment docs.

Copy link
Collaborator

@Kukovec Kukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token

@konnov konnov enabled auto-merge July 8, 2022 13:54
@konnov konnov merged commit 622aac5 into unstable Jul 8, 2022
@thpani thpani deleted the ik/variants-howto1938 branch July 8, 2022 14:56
@apalache-bot apalache-bot mentioned this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the types HOWTO
5 participants