Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the types tutorial #1942

Merged
merged 8 commits into from
Jul 8, 2022
Merged

Update the types tutorial #1942

merged 8 commits into from
Jul 8, 2022

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Jul 7, 2022

Closes #1939. This PR update the tutorial on the type checker, using the new records and giving pointers to variants. I have made it shorter and, hopefully, simpler.

@konnov konnov requested review from thpani and bugarela July 7, 2022 20:54
@konnov konnov requested a review from shonfeder as a code owner July 7, 2022 20:54
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #1942 (306a0cc) into unstable (caec3b4) will not change coverage.
The diff coverage is n/a.

❗ Current head 306a0cc differs from pull request most recent head b582b34. Consider uploading reports for the commit b582b34 to get more accurate results

@@            Coverage Diff            @@
##           unstable    #1942   +/-   ##
=========================================
  Coverage     77.09%   77.09%           
=========================================
  Files           415      415           
  Lines         12676    12676           
  Branches        568      568           
=========================================
  Hits           9772     9772           
  Misses         2904     2904           
Impacted Files Coverage Δ
...a/at/forsyte/apalache/tla/lir/TlaLevelFinder.scala 97.36% <0.00%> (-2.64%) ⬇️
...he/io/annotations/parser/CommentPreprocessor.scala 97.80% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622aac5...b582b34. Read the comment docs.

Copy link
Collaborator

@thpani thpani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claiming the review token – I agreed with @konnov to push minor improvements directly to this branch.

Copy link
Collaborator

@thpani thpani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I've pushed some suggestions for minor improvements in 25f9dce, 6f8e0e5, 50e64b8. @konnov please check if you think they're helpful.

@konnov konnov enabled auto-merge July 8, 2022 13:54
@konnov konnov merged commit 956c4d8 into unstable Jul 8, 2022
@apalache-bot apalache-bot mentioned this pull request Jul 11, 2022
@shonfeder shonfeder deleted the ik/types-tutorial1939 branch July 21, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the types tutorial
4 participants