-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the types tutorial #1942
Conversation
Codecov Report
@@ Coverage Diff @@
## unstable #1942 +/- ##
=========================================
Coverage 77.09% 77.09%
=========================================
Files 415 415
Lines 12676 12676
Branches 568 568
=========================================
Hits 9772 9772
Misses 2904 2904
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claiming the review token – I agreed with @konnov to push minor improvements directly to this branch.
I think it makes more sense in this order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #1939. This PR update the tutorial on the type checker, using the new records and giving pointers to variants. I have made it shorter and, hopefully, simpler.