Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of set filter rule with SMT arrays #2057

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Conversation

rodrigo7491
Copy link
Collaborator

@rodrigo7491 rodrigo7491 commented Aug 10, 2022

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

This PR removes a redundant membership check in the set filter rule, as suggested by @konnov a while back.

@rodrigo7491 rodrigo7491 added the Farrays Feature: New SMT encoding with arrays label Aug 10, 2022
@rodrigo7491 rodrigo7491 added this to the X1: Arrays Encoding milestone Aug 10, 2022
@rodrigo7491 rodrigo7491 self-assigned this Aug 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #2057 (6592b3f) into main (af68343) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2057      +/-   ##
==========================================
- Coverage   77.75%   77.73%   -0.02%     
==========================================
  Files         425      425              
  Lines       12998    12996       -2     
  Branches      580      585       +5     
==========================================
- Hits        10106    10103       -3     
- Misses       2892     2893       +1     
Impacted Files Coverage Δ
...rsyte/apalache/tla/bmcmt/rules/SetFilterRule.scala 90.47% <100.00%> (-0.44%) ⬇️
...a/at/forsyte/apalache/tla/lir/TlaLevelFinder.scala 97.36% <0.00%> (-2.64%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rodrigo7491 rodrigo7491 merged commit 5d365e9 into main Aug 10, 2022
@rodrigo7491 rodrigo7491 deleted the ro/filter-update branch August 10, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Farrays Feature: New SMT encoding with arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants