Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parser position to TLCConfigurationError message #209

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Add parser position to TLCConfigurationError message #209

merged 1 commit into from
Aug 25, 2020

Conversation

shonfeder
Copy link
Contributor

Useful for users and for us when debugging (as in the case of #208).

With this change, lexer errors now look like:

Configuration error (see the manual):   > Could not parse TLC configuration in BlockingQueue.cfg at position 4.17: string matching regex '\z' expected but '{' found E@00:14:23.070

Add parser position to TLCConfigurationError message
9f62555 
Useful for users and for us when debugging
@shonfeder shonfeder requested a review from konnov August 24, 2020 04:44
konnov
konnov approved these changes Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That definitely improves usability!

@shonfeder shonfeder merged commit 529870b into unstable Aug 25, 2020
@shonfeder shonfeder deleted the shon/parser-location-in-tlc-config-error branch August 25, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konnov konnov konnov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shonfeder @konnov