Raise an error on invalid keys in configuration #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, unexpected keys in a configuration source were silently ignored. This led to invalid configuration values (e.g., due to configuration format updates or due to typos) being silently ignored. This addition ensures we raise an error on unexpected keys in configuration sources.
shonfeder
added this to the X10: Bugfixing, maintenance, small usability improvements milestone
shonfeder
force-pushed
the
shon/cfg-err-on-invalid-keys
branch
from
98536de
to
949ec0d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2125 +/- ##
==========================================
- Coverage 77.17% 77.16% -0.01%
==========================================
Files 424 424
Lines 13830 13831 +1
Branches 1875 1899 +24
==========================================
Hits 10673 10673
- Misses 3157 3158 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, unexpected keys in a configuration source were silently
ignored. This led to invalid configuration values (e.g., due to
configuration format updates or due to typos) being silently ignored.
This addition ensures we raise an error on unexpected keys in
configuration sources.
This was spun out of ongoing work on #2121.
make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionality