Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report an error when --max-error > 1 and no --view is provided #2144

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Sep 2, 2022

Closes #1004. Closes #2139. This is the simplest fix to the problem that occurred several times. Since a default view (equal to the whole state) would slow down the search beyond reasonable, we simply tell the user to find a good view, when --max-error > 1.

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Entries added to ./unreleased/ for any new functionality

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #2144 (2ae33ca) into main (970ab4d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
- Coverage   77.14%   77.13%   -0.01%     
==========================================
  Files         423      423              
  Lines       13845    13848       +3     
  Branches     1879     1884       +5     
==========================================
+ Hits        10681    10682       +1     
- Misses       3164     3166       +2     
Impacted Files Coverage Δ
...ala/at/forsyte/apalache/infra/passes/options.scala 0.00% <0.00%> (ø)
...at/forsyte/apalache/tla/tooling/opt/CheckCmd.scala 0.00% <0.00%> (ø)
.../forsyte/apalache/tla/pp/ConstSimplifierBase.scala 97.70% <0.00%> (+1.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shonfeder shonfeder enabled auto-merge (squash) September 9, 2022 12:04
@shonfeder shonfeder enabled auto-merge (squash) September 9, 2022 12:05
@shonfeder shonfeder merged commit bf1e8f4 into main Sep 9, 2022
@apalache-bot apalache-bot mentioned this pull request Sep 12, 2022
@thpani thpani deleted the igor/default-view1004 branch October 17, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants