Make the server port configurable #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
requested review from
thpani and
Kukovec
and removed request for
thpani
- Adds `server` section to our configuration enabling configuration of server settings via config file. - Adds a corresponding `Server` `OptionGroup` to validate config values. - Adds a `port` CLI argument, to allow supplying the port at time of command invocation. - Adds an `RpcServer` class so that the port can be configured when the class is instantiated.
shonfeder
force-pushed
the
shai/make-port-configurable
branch
from
a2d1d48
to
4830a49
Compare
Codecov Report
@@ Coverage Diff @@
## main #2264 +/- ##
==========================================
- Coverage 78.46% 78.40% -0.07%
==========================================
Files 433 433
Lines 14641 14655 +14
Branches 2055 2040 -15
==========================================
+ Hits 11488 11490 +2
- Misses 3153 3165 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serversection to our configuration enabling configuration ofserver settings via config file.
ServerOptionGroupto validate config values.portCLI argument, to allow supplying the port at time ofcommand invocation.
RpcServerclass so that the port can be configured whenthe class is instantiated.
make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionality