Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify records in TypeOK #2570

Merged
merged 5 commits into from
Jun 2, 2023
Merged

Simplify records in TypeOK #2570

merged 5 commits into from
Jun 2, 2023

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented May 26, 2023

Now that we have precise type-checking for types (#401), rewrite membership tests between records and type-defining sets.

Closes #723

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

@thpani thpani requested a review from konnov May 26, 2023 12:46
@thpani thpani requested a review from Kukovec as a code owner May 26, 2023 12:46
@thpani thpani self-assigned this May 26, 2023
@thpani thpani force-pushed the th/simplify-typeok-records branch from 72a67f8 to e89caef Compare May 26, 2023 14:37
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e363a4f). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2570   +/-   ##
=======================================
  Coverage        ?   78.49%           
=======================================
  Files           ?      445           
  Lines           ?    15631           
  Branches        ?     2538           
=======================================
  Hits            ?    12270           
  Misses          ?     3361           
  Partials        ?        0           
Impacted Files Coverage Δ
...syte/apalache/tla/pp/SetMembershipSimplifier.scala 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@shonfeder shonfeder enabled auto-merge June 2, 2023 18:32
@shonfeder shonfeder merged commit 412c930 into main Jun 2, 2023
@thpani thpani deleted the th/simplify-typeok-records branch June 4, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Use types to simplify TypeOK
4 participants