Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer propagation fix for powerset-cherrypick #2607

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Pointer propagation fix for powerset-cherrypick #2607

merged 3 commits into from
Jun 21, 2023

Conversation

Kukovec
Copy link
Collaborator

@Kukovec Kukovec commented Jun 20, 2023

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

closes #2606

@Kukovec Kukovec requested a review from konnov June 20, 2023 12:04
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #2607 (1eb6c56) into main (bc2f7e1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
+ Coverage   78.43%   78.45%   +0.02%     
==========================================
  Files         445      445              
  Lines       15642    15645       +3     
  Branches     2552     2562      +10     
==========================================
+ Hits        12269    12275       +6     
+ Misses       3373     3370       -3     
Impacted Files Coverage Δ
...syte/apalache/tla/bmcmt/rules/aux/CherryPick.scala 93.80% <100.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a right fix

Kukovec and others added 2 commits June 20, 2023 17:14
Co-authored-by: Igor Konnov <igor@informal.systems>
@Kukovec Kukovec merged commit 39b23f4 into main Jun 21, 2023
@Kukovec Kukovec deleted the jk/2606 branch June 21, 2023 10:04
@thpani
Copy link
Collaborator

thpani commented Jun 21, 2023

Shouldn't this update the changelog, so we bump the version when cutting a release?

@Kukovec
Copy link
Collaborator Author

Kukovec commented Jun 21, 2023

I didn't think this ticked "Entries added to ./unreleased/ for any new functionality", but following the link, I guess bugfixes also qualify. We should update the PR template, "any new functionality" is imprecise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CherryPick rule for powersets incorrectly propagates pointers
4 participants