Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase max inbound gRPC message size #2623

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Increase max inbound gRPC message size #2623

merged 3 commits into from
Jun 30, 2023

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented Jun 30, 2023 •
edited
Loading

Increase max inbound gRPC message size to 8MB

This fixes an issue where large-enough Quint specs fail with

io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: gRPC message exceeds maximum size 4194304: 5177182

Closes #2622

ℹ️ Auto-merge is ON

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

@thpani thpani requested review from konnov, shonfeder and Kukovec June 30, 2023 15:07
@thpani thpani enabled auto-merge (squash) June 30, 2023 15:09
@shonfeder
Copy link
Contributor

shonfeder commented Jun 30, 2023 •
edited
Loading

Awesome! Thanks :D

Is this the largest possible size? If not, should we just use that?

@thpani
Copy link
Collaborator Author

thpani commented Jun 30, 2023

Is this the largest possible size? If not, should we just use that?

No, the max is Int.MaxValue. But I think we shouldn't generally allow 2GB gRPC messages.
We'll maybe have to iterate to figure out a sensible default.

@thpani thpani disabled auto-merge June 30, 2023 15:15
@thpani thpani enabled auto-merge (squash) June 30, 2023 15:20
@shonfeder
Copy link
Contributor

Ok. Makes sense. Thanks so much for this fix!!

@thpani thpani merged commit f9c6084 into main Jun 30, 2023
@thpani thpani deleted the th/grpc-msg-size branch June 30, 2023 16:11
@apalache-bot apalache-bot mentioned this pull request Jun 30, 2023
Merged
@konnov konnov mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shonfeder shonfeder shonfeder approved these changes

@konnov konnov Awaiting requested review from konnov

@Kukovec Kukovec Awaiting requested review from Kukovec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shai fails with RESOURCE_EXHAUSTED: gRPC message exceeds maximum size
2 participants
@thpani @shonfeder