Use single typevar map for entire spec #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpani
force-pushed
the
th/one-typevar-map
branch
2 times, most recently
from
5fe1cee
to
2818928
Compare
Codecov Report
@@ Coverage Diff @@
## th/refactor-quint #2629 +/- ##
=====================================================
- Coverage 78.49% 78.49% -0.01%
=====================================================
Files 447 447
Lines 15654 15653 -1
Branches 2553 2544 -9
=====================================================
- Hits 12288 12287 -1
Misses 3366 3366
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thpani
force-pushed
the
th/one-typevar-map
branch
from
2818928
to
ecfea24
Compare
thpani
force-pushed
the
th/one-typevar-map
branch
from
ecfea24
to
22df786
Compare
konnov
approved these changes
Jul 3, 2023
| * QuintTypeConverter.getVarNo() for details). | ||
| */ | ||
| object QuintTypeConverter { | ||
| def apply(quintType: QuintType): TlaType1 = new QuintTypeConverter().convert(quintType) |
There was a problem hiding this comment.
Good catch! I can see how the companion object was creating a new instance every time
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single type converter for an entire quint spec.
We previously used one type converter per sub-expression. This re-initialized the map for translating Quint type variables (named) to Apalache TypeSystem 1 type variables (numbered), causing wrong type annotations. For example the type of the following Quint was translated as
(a,a) => {src: a, ts: a}.Tests added for any new codemake fmt-fix(or had formatting run automatically on all files edited)Documentation added for any new functionality./unreleased/for any new functionality