Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Quint open row tuples to sparse tuples #2634

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented Jul 5, 2023

Translate Quint open row tuples to sparse tuples.

Also fixes an offset in the previous (non-sparse) tuple test.

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

@thpani thpani requested a review from konnov July 5, 2023 14:41
@thpani thpani self-assigned this Jul 5, 2023
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #2634 (dcd03d9) into main (02d7cd0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2634   +/-   ##
=======================================
  Coverage   78.48%   78.49%           
=======================================
  Files         447      447           
  Lines       15654    15656    +2     
  Branches     2553     2518   -35     
=======================================
+ Hits        12286    12289    +3     
+ Misses       3368     3367    -1     
Impacted Files Coverage Δ
...forsyte/apalache/io/quint/QuintTypeConverter.scala 97.43% <100.00%> (+0.13%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thpani thpani enabled auto-merge July 6, 2023 09:46
@thpani thpani merged commit cc2e718 into main Jul 6, 2023
10 checks passed
@thpani thpani deleted the th/quint-sparse-tuples branch July 6, 2023 10:28
@thpani thpani mentioned this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants