StratifiedRules: Set enumeration #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2637 +/- ##
==========================================
- Coverage 78.52% 78.51% -0.01%
==========================================
Files 451 452 +1
Lines 15705 15722 +17
Branches 2572 2552 -20
==========================================
+ Hits 12332 12344 +12
- Misses 3373 3378 +5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thpani
approved these changes
Jul 6, 2023
Comment on lines
+37
to
+40
| setT match { | ||
| case SetT1(_) => () | ||
| case _ => throw new TypingException("Expected a finite set, found: " + setT, ex.ID) | ||
| } |
There was a problem hiding this comment.
Do we need this extra check here?
There was a problem hiding this comment.
Strictly speaking, no, but I'd like to keep the sanity check here. A fair few translation rules work on Untyped() expressions, if they just check syntax, this is one of the ones where this isn't the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionalitycloses #2636