Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize QuintInt.value as BigInt #2654

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Deserialize QuintInt.value as BigInt #2654

merged 4 commits into from
Jul 20, 2023

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented Jul 20, 2023

Deserialize QuintInt.value as BigInt

Together with informalsystems/quint#1059, closes informalsystems/quint#1055

Closes #2653

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and small fix. Amazing!

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #2654 (6524e9c) into main (07b3ed2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2654      +/-   ##
==========================================
- Coverage   78.53%   78.53%   -0.01%     
==========================================
  Files         454      455       +1     
  Lines       15771    15795      +24     
  Branches     2558     2573      +15     
==========================================
+ Hits        12386    12404      +18     
- Misses       3385     3391       +6     
Impacted Files Coverage Δ
...n/scala/at/forsyte/apalache/io/quint/QuintIR.scala 81.03% <ø> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thpani thpani merged commit fee49ef into main Jul 20, 2023
10 checks passed
@thpani thpani deleted the th/fix-quint-bigint branch July 20, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialize JSON QuintInt into BigInt quint verify converts big integers to MAX_INT somewhere
4 participants