Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Quint empty tuples into uninterpreted types/values #2869

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

bugarela
Copy link
Collaborator

@bugarela bugarela commented Mar 21, 2024

Hello :octocat:

This is needed as a consequence of informalsystems/quint#1406, which started because we can't write empty records in TLA+ directly. In the end, we decided to use uninterpreted types/values to represent the unit type/value.

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.89%. Comparing base (8366559) to head (1cf2a58).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2869      +/-   ##
==========================================
- Coverage   78.91%   78.89%   -0.03%     
==========================================
  Files         467      467              
  Lines       15963    15966       +3     
  Branches     2589     2577      -12     
==========================================
- Hits        12597    12596       -1     
- Misses       3366     3370       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bugarela bugarela merged commit b7a583e into main Mar 21, 2024
10 checks passed
@apalache-bot apalache-bot mentioned this pull request Mar 21, 2024
@bugarela bugarela deleted the gabriela/empty-tuple-as-unit branch March 25, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants