Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cronjob for prepare-release workflow #2894

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

bugarela
Copy link
Collaborator

@bugarela bugarela commented May 6, 2024

Hello :octocat:

We have this cronjob preparing a release every Monday, but it doesn't make sense anymore as there isn't a continuous flow of changes to this project currently. It is annoying because it creates a branch for the next release, and whenever I actually want to cut a release, the branch is already taken and it errors out - or something like that - and I have to remember to close the bot's PR and delete it's branch.

This simply removes that cronjob. We can easily add it back if it starts making sense again.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.89%. Comparing base (99b93bb) to head (67d9e81).

❗ Current head 67d9e81 differs from pull request most recent head 1030a14. Consider uploading reports for the commit 1030a14 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2894      +/-   ##
==========================================
- Coverage   78.90%   78.89%   -0.02%     
==========================================
  Files         467      467              
  Lines       15975    15975              
  Branches     2556     2556              
==========================================
- Hits        12605    12603       -2     
- Misses       3370     3372       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bugarela bugarela requested a review from p-offtermatt May 6, 2024 12:33
Copy link
Collaborator

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change for now! Maybe it needs to be added back in the future :)

@bugarela bugarela enabled auto-merge May 6, 2024 12:56
@bugarela bugarela merged commit 6d69a24 into main May 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants