improve the error message about expanding powersets #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konnov
requested review from
Kukovec and
thpani
and removed request for
rodrigo7491
thpani
approved these changes
Aug 25, 2024
| + " \\A S \\in SUBSET T: P or \\E S \\in SUBSET T: P") | ||
| logger.error("Try to decrease the cardinality of the base set T, or avoid enumeration.") | ||
| val msg = | ||
| s"Attempted to expand SUBSET of size 2^${elems.size}, whereas the built-in limit is ${Limits.POWSET_MAX_SIZE}" |
There was a problem hiding this comment.
Printing 1048576 here may look confusing to the user.
Why not store Limits.POWSET_MAX_SIZE as the number of elements?
Then you can directly compare elems.size above and print it here as a power of 2.
There was a problem hiding this comment.
That's true. I will fix that :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply improves error reporting for the case when
SUBSET _has to be expanded to a very large set:RewriterKnownLimitationErrorinstead ofRewriterException, which would ask the user to file a bug reportmake fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionalityCurrently, the source location of the problematic code is not properly identified, due to multiple iterations of the rewriter. We could try to recover the source location when unwinding the rewriting stack. However, this would require a more careful refactoring.