Propagate z3 parameters in the tuning options #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konnov
requested review from
Kukovec,
thpani and
bugarela
and removed request for
rodrigo7491
This was referenced Sep 18, 2024
thpani
approved these changes
Sep 23, 2024
mod-infra/src/main/scala/at/forsyte/apalache/infra/log/LogbackConfigurator.scala
Outdated
Show resolved
Hide resolved
mod-infra/src/main/scala/at/forsyte/apalache/infra/log/LogbackConfigurator.scala
Outdated
Show resolved
Hide resolved
tla-bmcmt/src/main/scala/at/forsyte/apalache/tla/bmcmt/passes/BoundedCheckerPassImpl.scala
Outdated
Show resolved
Hide resolved
…Configurator.scala Co-authored-by: Thomas Pani <thomas.pani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2315.
This PR adds the ability to pass z3 tuning parameters right in the Apalache fine tuning parameters. This is a feature that we should have implemented long time ago.
The parameters are now parsed in
FineTuningParser. Initially, I tried to use pureconfig. However, it is too opinionated and it needs more workarounds than it helps. Writing a trivial parameter parser is much easier than fiddling with pureconfig, e.g., propagating product hints via implicits.make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionality