Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

produce true on distinct for less than 2 elements #3005

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Sep 27, 2024

Closes #2964. Simply translate distinst into true, when we have less than two subexpressions. It's only relevant for replaying SMT logs in CVC5, but it was sufficiently annoying for me to fix it.

@konnov konnov marked this pull request as ready for review September 27, 2024 16:00
@konnov konnov requested a review from thpani September 27, 2024 16:00
Copy link
Collaborator

@thpani thpani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! We should appease the SMT-LIB gods :D

.unreleased/bug-fixes/distinct-on-singleton.md Outdated Show resolved Hide resolved
Co-authored-by: Thomas Pani <thomas.pani@gmail.com>
@konnov konnov merged commit 2734569 into main Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not produce distinct on singleton
2 participants