Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unroller fix #344

Merged
merged 5 commits into from
Dec 4, 2020
Merged

Unroller fix #344

merged 5 commits into from
Dec 4, 2020

Conversation

Kukovec
Copy link
Collaborator

@Kukovec Kukovec commented Nov 29, 2020

closes #129
closes #131
closes #274
closes #309

@Kukovec Kukovec requested a review from konnov November 29, 2020 19:35
Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me! I have just a couple questions and a suggestion or two.

Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. That brings us one step closer to using the new type checker!

test/tla/Rec2.tla Show resolved Hide resolved
test/tla/Rec2.tla Show resolved Hide resolved
Comment on lines +14 to +17
* For each recursive operator A the user must define two additional TLA+ operators,
* - [UNROLL_TIMES_PREFIX]_A
* - [UNROLL_DEFAULT_PREFIX]_A
*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this markdown-like commenting work in javadoc? I think you have to use a bit of HTML here, e.g., <p>...</p> and <ul><li>...</li></ul>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants