Fix CI formatting check #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
force-pushed
the
shon/fix-scalafmt-on-ci
branch
from
eb13ae7
to
ad02a4b
Compare
We "ratchet" our formatting checks, which means we only check files that have changed relative to origin/unstable. This makes sure we have fetched the latest changes before running those checks, so we're getting an accurate report.
shonfeder
force-pushed
the
shon/fix-scalafmt-on-ci
branch
from
ad02a4b
to
89b2084
Compare
|
This only affects the formatting check, so I only waited for that to pass in CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We "ratchet" our formatting checks, which means we only check files that
have changed relative to
origin/unstable. This makes sure we havefetched the latest changes before running those checks, so we're getting
an accurate report.
Apparently the checkout action doesn't fetch our remote branches, but we need
unstable for our ratcheted format checking.
This is causing the formatting check to fail on on #503 and #467