Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up the operator names #726

Merged
merged 9 commits into from
Apr 13, 2021
Merged

Cleaning up the operator names #726

merged 9 commits into from
Apr 13, 2021

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Apr 11, 2021

This PR closes #634. I have made a pass over operator names and introduced verbose and readable names, instead of keeping the obfuscated ASCII notation. This is essential for the JSON format.

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entry added to UNRELEASED.md for any new functionality

@konnov konnov mentioned this pull request Apr 12, 2021
Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with two minor typo fixes

@konnov konnov merged commit 9587968 into unstable Apr 13, 2021
@konnov konnov deleted the igor/names634 branch April 13, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Standardize operator names in the IR
2 participants