Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerating counterexamples #833

Merged
merged 18 commits into from
Jun 11, 2021
Merged

Enumerating counterexamples #833

merged 18 commits into from
Jun 11, 2021

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented May 18, 2021

This PR closes #542, it implements the approach discussed in #827

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entry added to UNRELEASED.md for any new functionality

Copy link
Collaborator

@Kukovec Kukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine, two general comments would be to include more (or more verbose) comments, especially for nested function defs, and to split your PRs into smaller chunks in the future.

private def assertPathOrConstraint(execution: EncodedExecution, pathConstraint: PathConstraint): Unit = {
if (execution.path.length >= pathConstraint.length) {
val constraints =
execution.path.tail.zip(pathConstraint.tail).map { case ((binding, _), cons) =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment explaining the .tails would be helpful.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I have added a comment.

@konnov konnov merged commit ab22a16 into unstable Jun 11, 2021
@shonfeder shonfeder deleted the igor/enum542 branch July 16, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exhaustive search via transition enumeration
2 participants