-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enumerating counterexamples #833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly fine, two general comments would be to include more (or more verbose) comments, especially for nested function defs, and to split your PRs into smaller chunks in the future.
tla-bmcmt/src/main/scala/at/forsyte/apalache/tla/bmcmt/SeqModelChecker.scala
Outdated
Show resolved
Hide resolved
private def assertPathOrConstraint(execution: EncodedExecution, pathConstraint: PathConstraint): Unit = { | ||
if (execution.path.length >= pathConstraint.length) { | ||
val constraints = | ||
execution.path.tail.zip(pathConstraint.tail).map { case ((binding, _), cons) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment explaining the .tail
s would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I have added a comment.
…lChecker.scala Co-authored-by: Kukovec <jkukovec@forsyte.at>
This PR closes #542, it implements the approach discussed in #827
make fmt-fix
(or had formatting run automatically on all files edited)