Restore support for avr-libcpp injection #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #993 (Restore support for avr-libcpp injection). Revert "Remove support for avr-libcpp injection (#988)" This reverts commit eaef140. picolibrary is a tightly coupled dependency for picolibrary-microchip-megaavr0 so it made sense to remove support for picolibrary injection. This is not the case for avr-libcpp.
apcountryman
added
priority-normal
apcountryman
added
status-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #993 (Restore support for avr-libcpp injection).
Revert "Remove support for avr-libcpp injection (#988)"
This reverts commit eaef140.
picolibrary is a tightly coupled dependency for
picolibrary-microchip-megaavr0 so it made sense to remove support for picolibrary injection. This is not the case for avr-libcpp.
This pull request:
Please mark the pull request as "Ready for review" and request a review when the pull
request is ready for a review.
If changes are requested, please discuss and/or address the review findings before
requesting a new review.
@apcountryman