Fix C/CD restart and decomp bit-for-bit issues #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modify gridcell + land block elimination for C/CD, using a larger stencil, needs to be investigate further - turn off maskhalo_dyn for C/CD, needs to be investigated further - Update omp_suite and gridsys_suite to extend testing - Add new histdbg option to turn on some output at each timestep to help debugging
- Add 2 day restart test, restart2
dabail10
approved these changes
Mar 14, 2022
|
Full test suite results are here, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Fix C/CD restart and decomp bit-for-bit issues
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
should be mostly bit-for-bit with cgridDEV and answer changes are due to fixes
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on Icepack or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
Please provide any additional information or relevant details below:
Fix non bit-for-bit for C/CD with different decompositions. Fixed two issues now noted in C/CD not bit-for-bit with different decomps CICE-Consortium/CICE#700, gridcell / land block elimination stencil for C/CD and maskhalo_dyn problem for C/CD. These need to be looked into further once the C/CD implementation is finalized and stencil is clearer.
Fix C/CD exact restart issue, now restarts pass with C/CD. Was an issue in the query_field implementation. Closes C/CD restarts CICE-Consortium/CICE#684
Add 2 day restart test, restart2
Update test suites
Add histdbg option turning on a bunch of history fields, some every timestep
Adjust some indentation and other minor changes