Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dyn C/CD halo updates to mask and bundle fields #81

Merged
merged 3 commits into from
Mar 19, 2022
Merged

Conversation

apcraig
Copy link
Owner

@apcraig apcraig commented Mar 18, 2022

PR checklist

  • Short (1 sentence) summary of your PR:
    Update dyn C/CD halo updates to mask and bundle fields
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    full test suite run on cheyenne intel, pgi, gnu. Bit-for-bit. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#5927d0d6f820c022775bd16f65b699be33fb1917
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Update dyn C/CD halo updates to mask and bundle fields
Used 5 point stencil for C/CD halo mask (similar to current land block elimination for C/CD). This may still be improved. See CICE-Consortium#700
Rename stack_velocity_field to stack_fields and overload

Rename stack_velocity_field to stack_fields and overload
Copy link
Collaborator

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will be interesting to see how much this changes computational performance.

@apcraig
Copy link
Owner Author

apcraig commented Mar 18, 2022

This seems to improve the dynamics time in the C/CD cases by about 10% for a sample test case. This gets us part of the way to matching B performance but still work to do.

@apcraig
Copy link
Owner Author

apcraig commented Mar 19, 2022

Reran full test suite, all good.

@apcraig apcraig merged commit de154be into cgridDEV Mar 19, 2022
@apcraig apcraig deleted the cgtestP branch August 17, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants