Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show the recoverable time when describing the cluster #329

Merged
merged 3 commits into from
May 7, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label May 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 35.10638% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 42.80%. Comparing base (752c2c9) to head (0e0a3b1).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/cmd/cluster/describe.go 25.35% 46 Missing and 7 partials ⚠️
pkg/cmd/cluster/describe_ops.go 60.00% 4 Missing ⚠️
pkg/cmd/cluster/operations.go 40.00% 3 Missing ⚠️
pkg/cmd/cluster/config_observer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   42.84%   42.80%   -0.05%     
==========================================
  Files         213      213              
  Lines       29031    29099      +68     
==========================================
+ Hits        12438    12455      +17     
- Misses      15059    15104      +45     
- Partials     1534     1540       +6     
Flag Coverage Δ
unittests 42.80% <35.10%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei
Copy link
Contributor Author

/approved

@wangyelei wangyelei merged commit d7100c8 into main May 7, 2024
12 checks passed
@wangyelei wangyelei deleted the support/show_recoverable_time branch May 7, 2024 09:28
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 7, 2024
@wangyelei
Copy link
Contributor Author

/cherry-pick release-0.9

Copy link

github-actions bot commented May 7, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/8982998935

github-actions bot pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants