Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VictoriaMetrics addon #479

Merged
merged 6 commits into from
May 29, 2024
Merged

feat: add VictoriaMetrics addon #479

merged 6 commits into from
May 29, 2024

Conversation

ButterBright
Copy link
Contributor

@ButterBright ButterBright commented Apr 29, 2024

@ButterBright ButterBright marked this pull request as ready for review May 8, 2024 06:41
- "--storageDataPath=/storage"
- --envflag.enable=true
- --envflag.prefix=VM_
- --loggerFormat=json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a parameter to determine whether to enable the ipv6? -enableTCP6

"WipeOut"
]
},
"replicas": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update replicas, cpu, memory per component w.r.t values.yaml
e.g. replicas -> vminsert.replicas


## @param vmstorage configs
##
vmstorage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an extra field, such that users can specify their storage class name.
e.g. refer to storageClassName in apecloud-mysql.

addons/victoria-metrics/Chart.yaml Outdated Show resolved Hide resolved
@@ -32,15 +32,55 @@
"WipeOut"
]
},
"replicas": {
"vminsert.replicas": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is an example of schme json.
https://www.arthurkoziel.com/validate-helm-chart-values-with-json-schemas/

Please refine the schme accordingly and make sure it works as expected. ( validate replicas/cpu/memory/ for each component)

@sophon-zt sophon-zt merged commit 053db17 into apecloud:main May 29, 2024
0 of 2 checks passed
@sophon-zt sophon-zt linked an issue Jun 5, 2024 that may be closed by this pull request
@sophon-zt
Copy link
Contributor

/cherry-pick release-0.9

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks-addons/actions/runs/9461618510

apecloud-bot pushed a commit that referenced this pull request Jun 11, 2024
sophon-zt pushed a commit that referenced this pull request Jun 11, 2024
sophon-zt pushed a commit that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] support VictoriaMetrics addon
4 participants