-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add VictoriaMetrics addon #479
Conversation
ButterBright
commented
Apr 29, 2024
•
edited by shanshanying
Loading
edited by shanshanying
- [Features] support VictoriaMetrics addon #600
- "--storageDataPath=/storage" | ||
- --envflag.enable=true | ||
- --envflag.prefix=VM_ | ||
- --loggerFormat=json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a parameter to determine whether to enable the ipv6? -enableTCP6
"WipeOut" | ||
] | ||
}, | ||
"replicas": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update replicas, cpu, memory per component w.r.t values.yaml
e.g. replicas -> vminsert.replicas
|
||
## @param vmstorage configs | ||
## | ||
vmstorage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an extra field, such that users can specify their storage class name.
e.g. refer to storageClassName
in apecloud-mysql.
@@ -32,15 +32,55 @@ | |||
"WipeOut" | |||
] | |||
}, | |||
"replicas": { | |||
"vminsert.replicas": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is an example of schme json.
https://www.arthurkoziel.com/validate-helm-chart-values-with-json-schemas/
Please refine the schme accordingly and make sure it works as expected. ( validate replicas/cpu/memory/ for each component)
/cherry-pick release-0.9 |
🤖 says: cherry pick action finished successfully 🎉! |
(cherry picked from commit 053db17)
(cherry picked from commit 053db17)
(cherry picked from commit 053db17)