Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API to reference cluster resources in Env and templates #5919

Merged
merged 46 commits into from
Dec 5, 2023

Conversation

leon-inf
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 24, 2023
@leon-inf leon-inf force-pushed the feature/cluster-resources-reference branch 3 times, most recently from 94ebb51 to b850d80 Compare November 24, 2023 08:33
@leon-inf leon-inf force-pushed the feature/cluster-resources-reference branch from b850d80 to 0c61c6b Compare November 24, 2023 08:53
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Nov 27, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 206 lines in your changes are missing coverage. Please review.

Comparison is base (4051671) 68.30% compared to head (24b5abe) 68.41%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/controller/component/vars.go 79.05% 67 Missing and 17 partials ⚠️
pkg/controller/component/synthesize_component.go 40.65% 44 Missing and 10 partials ⚠️
pkg/controller/component/component_class_utils.go 53.33% 18 Missing and 3 partials ⚠️
...apps/v1alpha1/componentresourceconstraint_types.go 0.00% 15 Missing ⚠️
...controller/builder/builder_component_definition.go 0.00% 7 Missing ⚠️
controllers/apps/transformer_component_vars.go 75.00% 4 Missing and 1 partial ⚠️
controllers/apps/class_controller.go 60.00% 2 Missing and 2 partials ⚠️
pkg/controller/component/component.go 62.50% 2 Missing and 1 partial ⚠️
pkg/controller/component/service_reference.go 76.92% 0 Missing and 3 partials ⚠️
pkg/controller/configuration/builtin_functions.go 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5919      +/-   ##
==========================================
+ Coverage   68.30%   68.41%   +0.11%     
==========================================
  Files         286      288       +2     
  Lines       32575    32951     +376     
==========================================
+ Hits        22251    22545     +294     
- Misses       8469     8529      +60     
- Partials     1855     1877      +22     
Flag Coverage Δ
unittests 68.41% <70.10%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf marked this pull request as ready for review November 30, 2023 09:43
@leon-inf leon-inf merged commit acb3113 into main Dec 5, 2023
74 checks passed
@leon-inf leon-inf deleted the feature/cluster-resources-reference branch December 5, 2023 08:46
@github-actions github-actions bot added this to the 5986 milestone Dec 5, 2023
@ahjing99 ahjing99 modified the milestones: 5986, Release 0.8.0 Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants