Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support component lifecycle action postProvision #6037

Merged
merged 12 commits into from
Dec 13, 2023

Conversation

Y-Rookie
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Dec 11, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (f3fc08f) 68.32% compared to head (2f498f3) 68.39%.
Report is 8 commits behind head on main.

❗ Current head 2f498f3 differs from pull request most recent head 2ad8319. Consider uploading reports for the commit 2ad8319 to get more accurate results

Files Patch % Lines
...g/controller/component/component_post_provision.go 58.01% 91 Missing and 19 partials ⚠️
pkg/controller/component/job_utils.go 53.70% 18 Missing and 7 partials ⚠️
...llers/apps/transformer_component_post_provision.go 68.42% 4 Missing and 2 partials ⚠️
...roller/component/component_definition_convertor.go 81.25% 5 Missing and 1 partial ⚠️
controllers/apps/operations/switchover.go 50.00% 0 Missing and 1 partial ⚠️
controllers/apps/operations/switchover_util.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6037      +/-   ##
==========================================
+ Coverage   68.32%   68.39%   +0.06%     
==========================================
  Files         292      295       +3     
  Lines       33441    33744     +303     
==========================================
+ Hits        22850    23079     +229     
- Misses       8698     8744      +46     
- Partials     1893     1921      +28     
Flag Coverage Δ
unittests 68.39% <60.89%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}

job, err := createPostProvisionJobIfNotExist(ctx, cli, cluster, comp, synthesizeComp)
if err != nil {
Copy link
Contributor

@wangyelei wangyelei Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the job fails, it must be manually intervened for this action. otherwise controller will requeue with an error.

Is it possible to use the ErrorTypeFatal type for this type of operation, and reconciled with this error after setting the component conditions to related condition.

If there are too many failed jobs, it may cause the controller to overload and lead the excessive delay for kubeblocks

@Y-Rookie Y-Rookie merged commit 37ad128 into main Dec 13, 2023
74 of 75 checks passed
@Y-Rookie Y-Rookie deleted the feature/support-component-postprovision branch December 13, 2023 05:23
@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 13, 2023
@Y-Rookie
Copy link
Collaborator Author

Y-Rookie commented Dec 13, 2023

/cherry-pick release-0.8

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/7191116009

Y-Rookie added a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants