-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support component lifecycle action postProvision #6037
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6037 +/- ##
==========================================
+ Coverage 68.32% 68.39% +0.06%
==========================================
Files 292 295 +3
Lines 33441 33744 +303
==========================================
+ Hits 22850 23079 +229
- Misses 8698 8744 +46
- Partials 1893 1921 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
} | ||
|
||
job, err := createPostProvisionJobIfNotExist(ctx, cli, cluster, comp, synthesizeComp) | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the job fails, it must be manually intervened for this action. otherwise controller will requeue with an error.
Is it possible to use the ErrorTypeFatal
type for this type of operation, and reconciled with this error after setting the component conditions to related condition.
If there are too many failed jobs, it may cause the controller to overload and lead the excessive delay for kubeblocks
/cherry-pick release-0.8 |
🤖 says: |
(cherry picked from commit 37ad128)
No description provided.