Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lorry support executing action commands #6474

Merged
merged 40 commits into from
Feb 27, 2024
Merged

Conversation

xuriwuyun
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jan 17, 2024
@xuriwuyun xuriwuyun changed the title feat: lorry support action commands feat: lorry support executing action commands Jan 17, 2024
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Feb 4, 2024
@xuriwuyun xuriwuyun marked this pull request as ready for review February 18, 2024 06:00
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (db5bd29) 66.35% compared to head (4ddaf0e) 66.33%.

❗ Current head 4ddaf0e differs from pull request most recent head ce8bac0. Consider uploading reports for the commit ce8bac0 to get more accurate results

Files Patch % Lines
pkg/controller/component/lorry_utils.go 79.73% 26 Missing and 5 partials ⚠️
pkg/controller/component/rsm_convertor.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6474      +/-   ##
==========================================
- Coverage   66.35%   66.33%   -0.03%     
==========================================
  Files         304      304              
  Lines       36507    36607     +100     
==========================================
+ Hits        24225    24284      +59     
- Misses      10184    10224      +40     
- Partials     2098     2099       +1     
Flag Coverage Δ
unittests 66.33% <80.24%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuriwuyun xuriwuyun merged commit 6998693 into main Feb 27, 2024
65 checks passed
@xuriwuyun xuriwuyun deleted the feature/lorry_support_cmd branch February 27, 2024 02:30
@github-actions github-actions bot added this to the Release 0.8.2 milestone Feb 27, 2024
@xuriwuyun
Copy link
Contributor Author

/cherry-pick release-0.8

Copy link

github-actions bot commented Mar 4, 2024

🤖 says: Error cherry-picking.

Auto-merging apis/apps/v1alpha1/componentdefinition_types.go
CONFLICT (content): Merge conflict in apis/apps/v1alpha1/componentdefinition_types.go
Auto-merging apis/apps/v1alpha1/zz_generated.deepcopy.go
Auto-merging config/crd/bases/apps.kubeblocks.io_componentdefinitions.yaml
CONFLICT (content): Merge conflict in config/crd/bases/apps.kubeblocks.io_componentdefinitions.yaml
Auto-merging controllers/apps/componentdefinition_controller.go
Auto-merging controllers/apps/componentdefinition_controller_test.go
Auto-merging deploy/helm/crds/apps.kubeblocks.io_componentdefinitions.yaml
CONFLICT (content): Merge conflict in deploy/helm/crds/apps.kubeblocks.io_componentdefinitions.yaml
Auto-merging docs/developer_docs/api-reference/cluster.md
Auto-merging pkg/constant/env.go
CONFLICT (content): Merge conflict in pkg/constant/env.go
Auto-merging pkg/controller/component/component_definition_convertor.go
Auto-merging pkg/controller/component/component_definition_convertor_test.go
Auto-merging pkg/controller/component/lorry_utils.go
CONFLICT (content): Merge conflict in pkg/controller/component/lorry_utils.go
Auto-merging pkg/controller/component/lorry_utils_test.go
CONFLICT (content): Merge conflict in pkg/controller/component/lorry_utils_test.go
Auto-merging pkg/controller/component/rsm_convertor.go
Auto-merging pkg/controller/rsm/types.go
Auto-merging pkg/lorry/operations/replica/checkrole.go
Auto-merging pkg/testutil/apps/constant.go
error: could not apply 6998693... feat: lorry support executing action commands (#6474)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Copy link

github-actions bot commented Mar 4, 2024

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/8137002971

xuriwuyun added a commit that referenced this pull request Mar 4, 2024
Co-authored-by: xuriwuyun <xuriwuyun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants