feat: new cluster topology and component version API #6582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ology' into feature/cluster-topology
Y-Rookie
reviewed
Feb 27, 2024
Y-Rookie
reviewed
Mar 8, 2024
Y-Rookie
reviewed
Mar 8, 2024
Y-Rookie
reviewed
Mar 8, 2024
Y-Rookie
reviewed
Mar 8, 2024
| } | ||
|
|
||
| if !validate(topology.Orders.StartupOrder) { | ||
| return fmt.Errorf("the components in startup order are different from those from definition") |
There was a problem hiding this comment.
There's a question here: according to this validation rule, the components defined in StartupOrder/ShutdownOrder/UpdateOrder must completely cover topology.Components. Is this expected? What if the user only expects some of the components to have dependencies?
There was a problem hiding this comment.
Yes, the expected behavior is to either specify no components or all components, this is the simplest and most accurate strategy.
leon-inf
force-pushed
the
feature/new-cluster-and-version-api
branch
from
0f1f4b0
to
cab0202
Compare
Y-Rookie
reviewed
Mar 11, 2024
Y-Rookie
approved these changes
Mar 14, 2024
|
/approve |
apecloud-bot
approved these changes
Mar 17, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.