Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reconfigure reconcile decouples cd/cv (#6609) #6629

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 58.24176% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 66.27%. Comparing base (51e30e6) to head (461e892).
Report is 45 commits behind head on main.

Files Patch % Lines
controllers/apps/configuration/relatedresource.go 62.50% 12 Missing and 6 partials ⚠️
...llers/apps/configuration/reconfigure_controller.go 46.42% 13 Missing and 2 partials ⚠️
apis/apps/v1alpha1/configuration_types.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6629      +/-   ##
==========================================
- Coverage   66.29%   66.27%   -0.03%     
==========================================
  Files         303      304       +1     
  Lines       36354    36348       -6     
==========================================
- Hits        24101    24088      -13     
- Misses      10159    10167       +8     
+ Partials     2094     2093       -1     
Flag Coverage Δ
unittests 66.27% <58.24%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 1, 2024
@sophon-zt sophon-zt merged commit 7f4f352 into main Mar 1, 2024
80 checks passed
@sophon-zt sophon-zt deleted the support/improvement-reconfigure-controller-decouples-clusterdefinition-and-clusterversion-issue6609 branch March 1, 2024 06:53
@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 1, 2024
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.8

Copy link

github-actions bot commented Mar 4, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8137753455

github-actions bot pushed a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test ci size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] reconfigure controller decouples clusterdefinition and clusterversion
3 participants