Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports to specify namespaces that the operator should manage #6641

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

leon-inf
Copy link
Contributor

fix #6614

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Feb 20, 2024
@apecloud-bot apecloud-bot requested a review from realzyy February 20, 2024 08:38
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 67.60563% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 66.34%. Comparing base (74dd34c) to head (c8b33eb).
Report is 9 commits behind head on main.

Files Patch % Lines
pkg/controllerutil/predicate.go 0.00% 15 Missing ⚠️
controllers/dataprotection/gc_controller.go 66.66% 2 Missing and 1 partial ⚠️
...ollers/dataprotection/log_collection_controller.go 82.35% 2 Missing and 1 partial ⚠️
...ers/workloads/replicatedstatemachine_controller.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6641      +/-   ##
==========================================
- Coverage   66.37%   66.34%   -0.04%     
==========================================
  Files         305      306       +1     
  Lines       36503    36502       -1     
==========================================
- Hits        24229    24216      -13     
- Misses      10181    10188       +7     
- Partials     2093     2098       +5     
Flag Coverage Δ
unittests 66.34% <67.60%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf force-pushed the feature/namespaces-to-manage branch 2 times, most recently from d66cda0 to 8ca9f8e Compare February 20, 2024 09:28
@leon-inf leon-inf force-pushed the feature/namespaces-to-manage branch from 8ca9f8e to 9ab0168 Compare February 20, 2024 09:29
@leon-inf leon-inf marked this pull request as ready for review February 20, 2024 09:30
@leon-inf leon-inf force-pushed the feature/namespaces-to-manage branch from a9a9a44 to c8b33eb Compare February 28, 2024 02:11
Copy link
Collaborator

@ldming ldming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ldming ldming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leon-inf leon-inf merged commit 15b0752 into main Mar 1, 2024
140 of 142 checks passed
@leon-inf leon-inf deleted the feature/namespaces-to-manage branch March 1, 2024 02:18
@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-interaction ci feature size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] Specify namespaces which kubeblocks should watch/observe
5 participants