Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Decoupling the dependency between clusterComponent and configuration naming rules #6658

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@apecloud-bot apecloud-bot added the dependencies Pull requests that update a dependency file label Feb 21, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cdb05a3) 66.16% compared to head (1dc41af) 66.33%.
Report is 7 commits behind head on main.

Files Patch % Lines
controllers/apps/component_controller.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6658      +/-   ##
==========================================
+ Coverage   66.16%   66.33%   +0.16%     
==========================================
  Files         304      304              
  Lines       36493    36493              
==========================================
+ Hits        24145    24206      +61     
+ Misses      10238    10186      -52     
+ Partials     2110     2101       -9     
Flag Coverage Δ
unittests 66.33% <75.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 22, 2024
@sophon-zt sophon-zt merged commit bbcd77c into main Feb 22, 2024
78 of 80 checks passed
@sophon-zt sophon-zt deleted the support/refine-component-controller-depends-configuration-naming-rules branch February 22, 2024 08:53
@github-actions github-actions bot added this to the Release 0.8.2 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test dependencies Pull requests that update a dependency file size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants