fix: reconfiguring does not take effect (#6664) #6665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophon-zt
requested review from
nayutah,
ldming,
heng4fun,
free6om and
wangyelei
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6665 +/- ##
==========================================
+ Coverage 66.25% 66.28% +0.02%
==========================================
Files 304 304
Lines 36506 36504 -2
==========================================
+ Hits 24188 24196 +8
+ Misses 10213 10211 -2
+ Partials 2105 2097 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ldming
approved these changes
Feb 22, 2024
|
/approve |
apecloud-bot
approved these changes
Feb 22, 2024
sophon-zt
deleted the
bugfix/reconfiguring-does-not-take-effect-when-using-reload-sync-mode-issue6664
branch
|
/cherry-pick release-0.8 |
|
🤖 says: cherry pick action finished successfully 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.