Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove reload dependency on CharacterType (#6666) #6668

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore: Remove reload dependency on CharacterType (#6666) #6668

merged 1 commit into from
Feb 27, 2024

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt linked an issue Feb 22, 2024 that may be closed by this pull request
[Features] config-manager support DSN render for starRocks #6666
Closed
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 22, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 66.29%. Comparing base (49ef259) to head (ffa6858).
Report is 14 commits behind head on main.

Files Patch % Lines
pkg/configuration/config_manager/reload_util.go 50.00% 3 Missing and 1 partial ⚠️
pkg/configuration/config_manager/config_handler.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6668      +/-   ##
==========================================
+ Coverage   66.25%   66.29%   +0.03%     
==========================================
  Files         304      304              
  Lines       36506    36520      +14     
==========================================
+ Hits        24188    24211      +23     
+ Misses      10213    10208       -5     
+ Partials     2105     2101       -4
Flag Coverage Δ
unittests 66.29% <53.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt changed the title chore: config-manager support dsn render(#6666) chore: Remove reloader's dependency on CharacterType (#6666) Feb 23, 2024
@apecloud-bot apecloud-bot added the dependencies Pull requests that update a dependency file label Feb 23, 2024
@sophon-zt sophon-zt changed the title chore: Remove reloader's dependency on CharacterType (#6666) chore: Remove reload dependency on CharacterType (#6666) Feb 23, 2024
@sophon-zt
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 27, 2024
@sophon-zt sophon-zt merged commit e002a14 into main Feb 27, 2024
86 checks passed
@sophon-zt sophon-zt deleted the feature/config-manager-support-dsn-render-for-starrocks-issue6666 branch February 27, 2024 02:55
@github-actions github-actions bot added this to the Release 0.8.2 milestone Feb 27, 2024
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.8

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8137739547

github-actions bot pushed a commit that referenced this pull request Mar 4, 2024
@sophon-zt
chore: Remove reload dependency on CharacterType (#6666) (#6668)
d632e5d 
(cherry picked from commit e002a14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayutah nayutah nayutah approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@ldming ldming Awaiting requested review from ldming

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@wangyelei wangyelei Awaiting requested review from wangyelei

@leon-inf leon-inf Awaiting requested review from leon-inf

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie

@realzyy realzyy Awaiting requested review from realzyy

Assignees
No one assigned
Labels
approved PR Approved Test area/user-interaction dependencies Pull requests that update a dependency file size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
Release 0.8.2
Development

Successfully merging this pull request may close these issues.

[Features] config-manager support DSN render for starRocks
3 participants
@sophon-zt @nayutah @apecloud-bot