Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: build pod management policy from update strategy #6670

Merged
merged 2 commits into from
Feb 27, 2024
Merged

chore: build pod management policy from update strategy #6670

merged 2 commits into from
Feb 27, 2024

Conversation

leon-inf
Copy link
Contributor

fix #6578

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 22, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 66.37%. Comparing base (74dd34c) to head (0a85413).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/controller/component/rsm_convertor.go 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6670      +/-   ##
==========================================
- Coverage   66.37%   66.37%   -0.01%     
==========================================
  Files         305      305              
  Lines       36503    36524      +21     
==========================================
+ Hits        24229    24242      +13     
- Misses      10181    10192      +11     
+ Partials     2093     2090       -3
Flag Coverage Δ
unittests 66.37% <52.17%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf changed the title chore: infer pod management policy from update strategy chore: build pod management policy from update strategy Feb 23, 2024
@leon-inf leon-inf marked this pull request as ready for review February 23, 2024 01:51
@leon-inf leon-inf force-pushed the support/pod-management-policy branch from 0b295ba to 4aba2f6 Compare February 27, 2024 02:24
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 27, 2024
@leon-inf leon-inf merged commit 853e6df into main Feb 27, 2024
86 of 88 checks passed
@leon-inf leon-inf deleted the support/pod-management-policy branch February 27, 2024 03:07
@leon-inf
Copy link
Contributor Author

/cherry-pick release-0.8

@github-actions github-actions bot added this to the Release 0.8.2 milestone Feb 27, 2024
@github-actions GitHub Actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8059042728

github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
@leon-inf
chore: build pod management policy from update strategy (#6670)
f0d9244 
(cherry picked from commit 853e6df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayutah nayutah nayutah left review comments

@Y-Rookie Y-Rookie Y-Rookie approved these changes

@shanshanying shanshanying shanshanying approved these changes

@realzyy realzyy Awaiting requested review from realzyy

@ldming ldming Awaiting requested review from ldming

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@wangyelei wangyelei Awaiting requested review from wangyelei

Assignees
No one assigned
Labels
area/user-interaction size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 0.8.2
Development

Successfully merging this pull request may close these issues.

[Features] Statefulset workload support ‘OrderedReady’ switch
5 participants
@leon-inf @Y-Rookie @shanshanying @nayutah @apecloud-bot