Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support automatic updating of resource-related parameters when v-scale and h-scale (#6273) #6690

Conversation

sophon-zt
Copy link
Contributor

@sophon-zt sophon-zt commented Feb 26, 2024

example:

  1. redis addon:
- name: redis-replication-config
  templateRef: redis7-config-template
  constraintRef: redis7-config-constraints
  namespace: {{ .Release.Namespace }}
  volumeName: redis-config
  reRenderResourceTypes: ## h-scale or v-scale trigger rerender
    - resources
    - replicas
  1. zookeeper addon:
- name: zookeeper-env
  namespace: {{ .Release.Namespace }}
  templateRef: zookeeper-env
  constraintRef: zookeeper-env-cc
  volumeName: zookeeper-env
  asEnvFrom:
    - zookeeper
  reRenderResourceTypes:  ## v-scale trigger rerender
    - replicas

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 26, 2024
@sophon-zt sophon-zt changed the title fix: fix the consistency issue of multi-threaded updates (#6273) fix: support auto reconfiguring paramters-resourced when v-scale and h-scale (#6273) Feb 26, 2024
@sophon-zt sophon-zt changed the title fix: support auto reconfiguring paramters-resourced when v-scale and h-scale (#6273) fix: support automatic updating of resource-related parameters when v-scale and h-scale (#6273) Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 62.68657% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 66.37%. Comparing base (9f91f8c) to head (3617ff7).
Report is 46 commits behind head on main.

❗ Current head 3617ff7 differs from pull request most recent head 55de593. Consider uploading reports for the commit 55de593 to get more accurate results

Files Patch % Lines
pkg/controllerutil/config_util.go 11.11% 8 Missing ⚠️
pkg/controller/configuration/config_utils.go 76.00% 4 Missing and 2 partials ⚠️
pkg/controller/configuration/pipeline.go 14.28% 5 Missing and 1 partial ⚠️
...ntrollers/apps/transformer_component_parameters.go 78.94% 3 Missing and 1 partial ⚠️
controllers/apps/transformer_component_tls.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6690      +/-   ##
==========================================
- Coverage   66.43%   66.37%   -0.07%     
==========================================
  Files         304      305       +1     
  Lines       36507    36568      +61     
==========================================
+ Hits        24254    24271      +17     
- Misses      10163    10194      +31     
- Partials     2090     2103      +13     
Flag Coverage Δ
unittests 66.37% <62.68%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 26, 2024
@sophon-zt sophon-zt marked this pull request as ready for review February 27, 2024 08:12
@sophon-zt
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 12, 2024
@sophon-zt sophon-zt merged commit a71940b into main Mar 12, 2024
68 checks passed
@sophon-zt sophon-zt deleted the feature/support-rerender-when-configuration-related-resource-updated-eg-v-scale-h-scale-version-or-tls-update-issue6273 branch March 12, 2024 03:12
@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 12, 2024
@sophon-zt sophon-zt linked an issue Mar 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test area/user-interaction enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
3 participants