Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backup and restore failed when using hostnetwork #6715

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 28, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 29, 2024
@wangyelei
Copy link
Contributor Author

/approved

@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 66.43%. Comparing base (853e6df) to head (6ea0586).
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/dataprotection/utils/utils.go 0.00% 6 Missing ⚠️
pkg/dataprotection/restore/builder.go 25.00% 2 Missing and 1 partial ⚠️
pkg/dataprotection/utils/envvar.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6715      +/-   ##
==========================================
- Coverage   66.49%   66.43%   -0.06%     
==========================================
  Files         305      305              
  Lines       36638    36649      +11     
==========================================
- Hits        24361    24349      -12     
- Misses      10182    10204      +22     
- Partials     2095     2096       +1     
Flag Coverage Δ
unittests 66.43% <8.33%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei merged commit 9f46d67 into main Feb 29, 2024
78 checks passed
@wangyelei wangyelei deleted the bugfix/mongodb_backup_faile_on_hostnetwork branch February 29, 2024 01:50
@wangyelei
Copy link
Contributor Author

/cherry-pick release-0.8

@github-actions github-actions bot added this to the Release 0.8.2 milestone Feb 29, 2024
Copy link

🤖 says: Error cherry-picking.

Auto-merging config/crd/bases/apps.kubeblocks.io_componentdefinitions.yaml
Auto-merging deploy/helm/crds/apps.kubeblocks.io_componentdefinitions.yaml
Auto-merging pkg/dataprotection/restore/builder.go
Auto-merging pkg/dataprotection/utils/envvar.go
Auto-merging pkg/dataprotection/utils/utils.go
CONFLICT (content): Merge conflict in pkg/dataprotection/utils/utils.go
error: could not apply 9f46d67... fix: backup and restore failed when using hostnetwork (#6715)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/8089827991

@wangyelei
Copy link
Contributor Author

/cherry-pick release-0.8

Copy link

🤖 says: Error cherry-picking.

Auto-merging config/crd/bases/apps.kubeblocks.io_componentdefinitions.yaml
Auto-merging deploy/helm/crds/apps.kubeblocks.io_componentdefinitions.yaml
Auto-merging pkg/dataprotection/restore/builder.go
Auto-merging pkg/dataprotection/utils/envvar.go
Auto-merging pkg/dataprotection/utils/utils.go
CONFLICT (content): Merge conflict in pkg/dataprotection/utils/utils.go
error: could not apply 9f46d67... fix: backup and restore failed when using hostnetwork (#6715)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/8089873295

wangyelei added a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants