feat: support ComponentDefinition custom annotations and Component inherit Cluster annotations #6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei and
leon-inf
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6724 +/- ##
==========================================
+ Coverage 66.25% 66.51% +0.25%
==========================================
Files 306 306
Lines 36870 36900 +30
==========================================
+ Hits 24430 24544 +114
+ Misses 10337 10269 -68
+ Partials 2103 2087 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
free6om
reviewed
Mar 4, 2024
| @@ -190,6 +190,13 @@ type ComponentDefinitionSpec struct { | |||
| // +optional | |||
| Labels map[string]string `json:"labels,omitempty"` | |||
|
|
|||
| // Defines static annotations that will be patched to all k8s resources created for the component. | |||
| // If a annotation key conflicts with any other system annotations or user-specified annotations, it will be silently ignored. | |||
| // This field is immutable. | |||
There was a problem hiding this comment.
then enforce it by a validation rule?
There was a problem hiding this comment.
then enforce it by a validation rule?
This is to keep consistency with other fields, and validation will be added once the API is finally stable.
free6om
approved these changes
Mar 4, 2024
|
/approve |
apecloud-bot
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.