-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor the opsDefinition to support task orchestration. #6735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyelei
requested review from
nayutah,
ldming,
heng4fun,
free6om and
Y-Rookie
as code owners
March 4, 2024 10:11
…ly, support workload and exec action.
wangyelei
force-pushed
the
feature/improve_opsdef
branch
from
March 4, 2024 10:32
1b656dc
to
d648643
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6735 +/- ##
==========================================
+ Coverage 66.37% 66.46% +0.09%
==========================================
Files 307 308 +1
Lines 36848 36770 -78
==========================================
- Hits 24458 24440 -18
+ Misses 10296 10233 -63
- Partials 2094 2097 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
free6om
approved these changes
Mar 5, 2024
ldming
reviewed
Mar 5, 2024
ldming
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the OpsDefinition to support task orchestration.
We provide the following three action operators(maybe mores):
workload
: will create a workload to execute the action. available types: [Job, Pod]exec
: will run a pod to dokubectl exec
for selected pod.resourceModifier
: patch your inputed CR. (TODO)...
And these code misses some test cases, I will I will add in the next PR.
Here's an example for switchover with lorry:
1. switchover opsDefinition:
2. do switchover for mysql cluster
Note: for workload action, you can use
sh /scripts/patch-extras-status.sh '[{"name":"test"}]'
to record your custom information in opsRequest.status.extras.