-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dynamic reload selected parameters policy (#6741) #6742
feat: support dynamic reload selected parameters policy (#6741) #6742
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6742 +/- ##
==========================================
- Coverage 66.52% 66.51% -0.02%
==========================================
Files 307 307
Lines 36878 36884 +6
==========================================
Hits 24534 24534
- Misses 10258 10263 +5
- Partials 2086 2087 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/approve |
/cherry-pick release-0.8 |
🤖 says: Error cherry-picking. |
🤖 says: |
This is an API addition (e.g., DynamicParameterSelectedPolicy) built on top of Patroni's support for dynamicAction and restartAction. The context is as follows:
Patroni's dynamic configuration parameters for PostgreSQL do not need to include static change parameters, as static and dynamic changes follow different logic. In contrast, Oceanbase (OB) requires all parameters to be changed via SQL. For example, if a user changes two parameters, such as config_key1=abcd and config_key2=1234; config_key1 is a static parameter requiring a restart, while config_key2 is a dynamic parameter.
For Patroni's dynamic update (DynamicAction): only config_key2=1234 can be executed during a dynamic change. However, for OB, both config_key1 and config_key2 need to be changed via SQL, followed by a pod restart.
Therefore, a new field, DynamicParameterSelectedPolicy, is added to differentiate these two scenarios and how to choose the parameter list for DynamicAction: whether to select [config_key2] or both [config_key1, config_key2].
If DynamicParameterPolicy = all, all updated parameters execute DynamicAction.
If DynamicParameterPolicy = dynamic, only parameters listed in DynamicParameters will execute DynamicAction.