Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore svc bug #6768

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: restore svc bug #6768

merged 1 commit into from
Mar 7, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei linked an issue Mar 7, 2024 that may be closed by this pull request
[BUG] the svc is not restored. #6767
Closed
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Mar 7, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.59%. Comparing base (20d29fa) to head (c8b9b26).
Report is 3 commits behind head on main.

Files Patch % Lines
controllers/apps/operations/restore.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6768      +/-   ##
==========================================
+ Coverage   66.52%   66.59%   +0.06%     
==========================================
  Files         308      308              
  Lines       36859    36867       +8     
==========================================
+ Hits        24521    24551      +30     
+ Misses      10251    10228      -23     
- Partials     2087     2088       +1
Flag Coverage Δ
unittests 66.59% <66.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei
Copy link
Contributor Author

/approved

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 7, 2024
@wangyelei wangyelei merged commit ebb7a49 into main Mar 7, 2024
81 of 82 checks passed
@wangyelei wangyelei deleted the bugfix/restore_svc_bug branch March 7, 2024 05:57
@wangyelei
Copy link
Contributor Author

/cherry-pick release-0.8

@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8183623679

github-actions bot pushed a commit that referenced this pull request Mar 7, 2024
@wangyelei
fix: restore svc bug (#6768)
2c5a7b5 
(cherry picked from commit ebb7a49)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@nayutah nayutah Awaiting requested review from nayutah

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie

Assignees
No one assigned
Labels
approved PR Approved Test bug enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 0.8.2
Development

Successfully merging this pull request may close these issues.

[BUG] the svc is not restored.
3 participants
@wangyelei @ldming @apecloud-bot