feat: support heterogeneous pods by managing pods directly #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
free6om
requested review from
nayutah,
ldming,
heng4fun,
wangyelei and
Y-Rookie
as code owners
nayutah
approved these changes
Mar 20, 2024
wangyelei
reviewed
Mar 20, 2024
| // Defines the name of the instance. | ||
| // Only applied when Replicas is 1. | ||
| // +optional | ||
| Name *string `json:"name,omitempty"` |
There was a problem hiding this comment.
why not using instanceName, Name gave me the illusion of being a template name
There was a problem hiding this comment.
This name should be unique, right？
| // group the pod templates by template.Name if set or by template.GenerateName | ||
| replicaTemplateGroups := make(map[string][]*podTemplateSpecExt) | ||
| for _, template := range podTemplates { | ||
| name := template.Name |
There was a problem hiding this comment.
template.name must be unique. otherwise will be override
There was a problem hiding this comment.
duplicate template.name is an invalid request and will be refused by the rsm2 controller.
| } | ||
| } | ||
| if isCreated(pod) && !isTerminating(pod) { | ||
| switch revision, ok := rsm.Status.UpdateRevisions[pod.Name]; { |
There was a problem hiding this comment.
If the replicas of RSM are large, will it cause the struct to swell?
There was a problem hiding this comment.
will add instance template compression API in next PR.
Y-Rookie
reviewed
Mar 21, 2024
wangyelei
approved these changes
Mar 21, 2024
Y-Rookie
reviewed
Mar 21, 2024
controllers/workloads/replicatedstatemachine_controller_test.go
Outdated
Show resolved
Hide resolved
Y-Rookie
approved these changes
Mar 21, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5799
pod name,pod name prefix,annotation,label,node name,node selector,toleration,image,resources,volume,volume mountandvolume claim template)todo:
annotation,label,tolerations,image,activeDeadlineSecondsandresources)