Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore cluster failed if exists node port service #6787

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

wangyelei
Copy link
Contributor

@wangyelei wangyelei commented Mar 11, 2024

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Mar 11, 2024
@wangyelei wangyelei linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.63%. Comparing base (e5a3019) to head (c000641).
Report is 1 commits behind head on main.

Files Patch % Lines
controllers/apps/operations/restore.go 33.33% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6787      +/-   ##
==========================================
- Coverage   65.76%   65.63%   -0.13%     
==========================================
  Files         309      309              
  Lines       37381    37386       +5     
==========================================
- Hits        24582    24539      -43     
- Misses      10719    10749      +30     
- Partials     2080     2098      +18     
Flag Coverage Δ
unittests 65.63% <33.33%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei merged commit 7cddbda into main Mar 11, 2024
77 of 85 checks passed
@wangyelei wangyelei deleted the bugfix/restore_node_port_faile branch March 11, 2024 02:58
@wangyelei
Copy link
Contributor Author

/cherry-pick release-0.8

@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 11, 2024
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8227028045

github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] restore should ignore NodePort SVC's ports.NodePort field
4 participants