Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configmap not found error during the cluster deleting and refine code (#6792) #6793

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt linked an issue Mar 11, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 65.62%. Comparing base (3882d3e) to head (9fd18a0).
Report is 1 commits behind head on main.

Files Patch % Lines
apis/apps/v1alpha1/config_meta.go 0.00% 52 Missing ⚠️
...ers/apps/configuration/configuration_controller.go 73.68% 3 Missing and 2 partials ⚠️
controllers/apps/configuration/config_util.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6793      +/-   ##
==========================================
- Coverage   65.74%   65.62%   -0.13%     
==========================================
  Files         309      310       +1     
  Lines       37527    37531       +4     
==========================================
- Hits        24671    24628      -43     
- Misses      10762    10800      +38     
- Partials     2094     2103       +9     
Flag Coverage Δ
unittests 65.62% <21.05%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 12, 2024
@sophon-zt sophon-zt merged commit caf2ed8 into main Mar 12, 2024
82 checks passed
@sophon-zt sophon-zt deleted the bugfix/configmap-not-found-error-when-cluster-deleting-issue6792 branch March 12, 2024 03:12
@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] configmap not found error when cluster deleting
3 participants